-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Privacy Pro settings footer #3679
Merged
samsymons
merged 4 commits into
release/1.119.0
from
michal/update-privacy-pro-settings-footer
Dec 19, 2024
Merged
Update to Privacy Pro settings footer #3679
samsymons
merged 4 commits into
release/1.119.0
from
michal/update-privacy-pro-settings-footer
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
samsymons
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
samsymons
pushed a commit
that referenced
this pull request
Dec 19, 2024
Task/Issue URL: https://app.asana.com/0/1142021229838617/1209014429605257/f Description: Following https://app.asana.com/0/1142021229838617/1208961863805375/f: Update the Privacy Pro settings to include link to Privacy Policy. Restore right alignment fro buttons on subscription dialogs. # Conflicts: # DuckDuckGo/Localizable.xcstrings
samsymons
added a commit
that referenced
this pull request
Dec 19, 2024
* main: CRCID Support when reporting crashes (#3653) Bump version to 1.119.0 (332) Update to Privacy Pro settings footer (#3679) Update to Privacy Pro settings footer (#3679) [Release PR] Update VPN localization (#3675) Bump version to 1.118.1 (331) Set marketing version to 1.118.1 [Release PR] Update VPN localization (#3675)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1142021229838617/1209014429605257/f
Description:
Following https://app.asana.com/0/1142021229838617/1208961863805375/f:
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation