Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Privacy Pro settings footer #3679

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Dec 19, 2024

Task/Issue URL: https://app.asana.com/0/1142021229838617/1209014429605257/f
Description:
Following https://app.asana.com/0/1142021229838617/1208961863805375/f:

  • Update the Privacy Pro settings to include link to Privacy Policy.
  • Restore right alignment fro buttons on subscription dialogs.

Steps to test this PR:

  • Verify footer of Privacy Pro settings when subscription is not active
  • Verify footer of Privacy Pro settings when subscription is active
  • Verify button placement on "Remove From This Device" dialog
Screenshot 2024-12-19 at 10 10 30 Screenshot 2024-12-19 at 10 08 01 Screenshot 2024-12-19 at 10 10 23

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@miasma13 miasma13 requested a review from samsymons December 19, 2024 10:03
Copy link
Contributor

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against db9c983

Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samsymons samsymons merged commit 8c0d849 into release/1.119.0 Dec 19, 2024
37 checks passed
@samsymons samsymons deleted the michal/update-privacy-pro-settings-footer branch December 19, 2024 16:50
samsymons pushed a commit that referenced this pull request Dec 19, 2024
Task/Issue URL: https://app.asana.com/0/1142021229838617/1209014429605257/f
Description:
Following https://app.asana.com/0/1142021229838617/1208961863805375/f:

Update the Privacy Pro settings to include link to Privacy Policy.
Restore right alignment fro buttons on subscription dialogs.
# Conflicts:
#	DuckDuckGo/Localizable.xcstrings
samsymons added a commit that referenced this pull request Dec 19, 2024
* main:
  Bump version to 1.119.0 (332)
  Update to Privacy Pro settings footer (#3679)
  [Release PR] Update VPN localization (#3675)
samsymons added a commit that referenced this pull request Dec 19, 2024
# By Anka (2) and others
* hotfix/1.118.1:
  Update to Privacy Pro settings footer (#3679)
  [Release PR] Update VPN localization (#3675)
  Bump version to 1.118.1 (331)
  Set marketing version to 1.118.1

# Conflicts:
#	Configuration/BuildNumber.xcconfig
#	Configuration/Version.xcconfig
samsymons added a commit that referenced this pull request Dec 19, 2024
* main:
  CRCID Support when reporting crashes (#3653)
  Bump version to 1.119.0 (332)
  Update to Privacy Pro settings footer (#3679)
  Update to Privacy Pro settings footer (#3679)
  [Release PR] Update VPN localization (#3675)
  Bump version to 1.118.1 (331)
  Set marketing version to 1.118.1
  [Release PR] Update VPN localization (#3675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants